Remove VotesERC20 from AzoriusTxBuilder #1645
Conversation
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
force-pushed
the
remove-voteserc20-from-azoriustxbuilder
branch
from
ffa9a66 to
e5fab96
Compare
| contract: Contract, | ||
| method: string, | ||
| params: any[], | ||
| const finishBuildingConractCall = ( |
There was a problem hiding this comment.
typo: finishBuildingConractCall -> finishBuildingContractCall
There was a problem hiding this comment.
gah. i almost just want to leave it as is for now, because fixing this will cause me to need to rebase all of the branches above this one 😅
i plan on consolidating this back into one function anyway, once the the ethers-style function can be removed. I'll deal with it then.
| @@ -184,6 +184,45 @@ export const buildContractCall = ( | |||
| ); | |||
| }; | |||
|
|
|||
| export const buildContractCall = ( | |||
There was a problem hiding this comment.
Is this meant to go away at some point? Noticing the -viem variant below.
adamgall
force-pushed
the
remove-votestokenmastercopycontract-from-usesafecontracts
branch
from
f0c3317 to
0829528
Compare
adamgall
force-pushed
the
remove-voteserc20-from-azoriustxbuilder
branch
from
e5fab96 to
a919284
Compare
adamgall
force-pushed
the
remove-votestokenmastercopycontract-from-usesafecontracts
branch
from
0829528 to
a2f5908
Compare
adamgall
force-pushed
the
remove-voteserc20-from-azoriustxbuilder
branch
from
a919284 to
ede0aa4
Compare
adamgall
force-pushed
the
remove-voteserc20-from-azoriustxbuilder
branch
from
ede0aa4 to
1f0e490
Compare
adamgall
force-pushed
the
remove-votestokenmastercopycontract-from-usesafecontracts
branch
from
a2f5908 to
f907412
Compare
| if (!this.predictedTokenAddress) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Is this defined when existing token is used for DAO Creation? Ie set to the existing token's address
There was a problem hiding this comment.
TBH not sure. I assumed (perhaps incorrectly?) that this check here was safe, because if you look at the old code on line 561, we were forcing the value to be valid (this.predictedTokenAddress!).
I could just put that ! back in on new line 574 and remove this conditional early exit, but I don't like ! in typescript.
I suppose I should go and manually test this out, huh
There was a problem hiding this comment.
In the case when a user brings their own token to new Azorius DAO creation, this.predictedTokenAddress gets set to that existing token address. So, this function executes as expected. Thanks for the call out here.
…stxbuilder Remove VotesERC20 from AzoriusTxBuilder
Please review and merge #1644 first.